In this changes added support Windows Server 2012 - #56

Thank you for reviewing my PR. I'll look at all the code flaws and try to fix them to meet your requirements. 1 сент. 2026 г., в 20:30, Sein Coray ***@***.***> написал(а): @s3inlc requested changes on this pull request. Thanks for your PR, I looked through the code and requested some changes regarding the code. Unfortunately I myself don't have a Windows Server setup to test on (neither a normal Windows setup to test if nothing existing breaks), so I may need a bit of time to have other people test it on their setup.

class Initialize: def __init__(self): self.config = Config() + # In windows server and windows server R2 uses cp1251 encoding + self.encoding = "utf-8" why does this need to be set as variable here when the only place where it is used is where 'utf-8' was already enforced there? Or how is this supposed to be changed on the class?

- 'powershell -Command "Get-CimInstance Win32_Processor | Select-Object -ExpandProperty Name"', - shell=True) + 'powershell -Command "Get-CimInstance Win32_Processor | Select-Object -ExpandProperty Name"', this indentation is inconsistent with the other parts where the subprocess commands are called (indented twice instead of just once)

video_controller = subprocess.check_output( - 'powershell -Command "Get-CimInstance Win32_VideoController | Select-Object -ExpandProperty Name"', - shell=True) - video_controller = self.decode_output(video_controller) - else: - processor_information = subprocess.check_output( - 'wmic cpu get name', - shell=True) - processor_information = self.decode_output(processor_information) - video_controller = subprocess.check_output('wmic path win32_VideoController get name', shell=True) + 'powershell -Command "Get-CimInstance Win32_VideoController | Select-Object -ExpandProperty Name"', this indentation is inconsistent with the other parts where the subprocess commands are called (indented twice instead of just once)

for source in (processor_information, video_controller): for line in source: line = line.rstrip("\r\n ") if line and line != "Name": devices.append(line) - this empty line helps for code readability, i.e. the section between linux and windows also is separated with an empty line, so it should remain also for consistency.